Am Montag, 21. August 2017, 11:23:55 CEST schrieb Tudor Ambarus: Hi Tudor, > > Oops, I missed the negation. When crypto_akcipher_set_priv_key succeeds > you return the akcipher_maxsize. Not a bad idea, you save few cpu > cycles. I was hoping to save some context switches. > > > crypto akcipher uses a dedicated function for determining the length of > > the output buffer, crypto_akcipher_maxsize. Should we add a new function > > pointer in struct af_alg_type that returns the maxsize? > > Your API is different from crypto's akcipher. Should we make them > identical? In the early days of the akcipher API it used to be the way algif_akcipher implements it today. Do you see a case where user space wants to deliberately ask for this value? As this value never changes after setting a key, I thought we can skip it for the user space interface. Ciao Stephan