Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> wrote: > Remove unnecessary static on local variable sha_dd. Such variable > is initialized before being used, on every execution path throughout > the function. The static has no benefit and, removing it reduces the > object file size. > > This issue was detected using Coccinelle and the following semantic patch: > https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci > > In the following log you can see a significant difference in the object > file size. This log is the output of the size command, before and after > the code change: > > before: > text data bss dec hex filename > 30005 10264 128 40397 9dcd drivers/crypto/atmel-sha.o > > after: > text data bss dec hex filename > 29934 10208 64 40206 9d0e drivers/crypto/atmel-sha.o > > Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> Patch applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
