On 7/31/2017 3:22 PM, Fabio Estevam wrote:
> Most of the dentry members from structure caam_drv_private
> are never used at all, so it is safe to remove them.
>
> Since debugfs_remove_recursive() is called, we don't need the
> file entries.
>
> Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx>
> ---
> Changes since v1:
> - Remove all the unused dentry members (Horia)
>
> drivers/crypto/caam/ctrl.c | 81 ++++++++++++++++----------------------------
> drivers/crypto/caam/intern.h | 8 -----
> drivers/crypto/caam/qi.c | 6 ++--
> 3 files changed, 32 insertions(+), 63 deletions(-)
>
> diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
> index 7338f15..dc65fed 100644
> --- a/drivers/crypto/caam/ctrl.c
> +++ b/drivers/crypto/caam/ctrl.c
> @@ -734,59 +734,38 @@ static int caam_probe(struct platform_device *pdev)
> ctrlpriv->total_jobrs, ctrlpriv->qi_present);
>
> #ifdef CONFIG_DEBUG_FS
> -
> - ctrlpriv->ctl_rq_dequeued =
> - debugfs_create_file("rq_dequeued",
> - S_IRUSR | S_IRGRP | S_IROTH,
> - ctrlpriv->ctl, &perfmon->req_dequeued,
> - &caam_fops_u64_ro);
> - ctrlpriv->ctl_ob_enc_req =
> - debugfs_create_file("ob_rq_encrypted",
> - S_IRUSR | S_IRGRP | S_IROTH,
> - ctrlpriv->ctl, &perfmon->ob_enc_req,
> - &caam_fops_u64_ro);
> - ctrlpriv->ctl_ib_dec_req =
> - debugfs_create_file("ib_rq_decrypted",
> - S_IRUSR | S_IRGRP | S_IROTH,
> - ctrlpriv->ctl, &perfmon->ib_dec_req,
> - &caam_fops_u64_ro);
> - ctrlpriv->ctl_ob_enc_bytes =
> - debugfs_create_file("ob_bytes_encrypted",
> - S_IRUSR | S_IRGRP | S_IROTH,
> - ctrlpriv->ctl, &perfmon->ob_enc_bytes,
> - &caam_fops_u64_ro);
> - ctrlpriv->ctl_ob_prot_bytes =
> - debugfs_create_file("ob_bytes_protected",
> - S_IRUSR | S_IRGRP | S_IROTH,
> - ctrlpriv->ctl, &perfmon->ob_prot_bytes,
> - &caam_fops_u64_ro);
> - ctrlpriv->ctl_ib_dec_bytes =
> - debugfs_create_file("ib_bytes_decrypted",
> - S_IRUSR | S_IRGRP | S_IROTH,
> - ctrlpriv->ctl, &perfmon->ib_dec_bytes,
> - &caam_fops_u64_ro);
> - ctrlpriv->ctl_ib_valid_bytes =
> - debugfs_create_file("ib_bytes_validated",
> - S_IRUSR | S_IRGRP | S_IROTH,
> - ctrlpriv->ctl, &perfmon->ib_valid_bytes,
> - &caam_fops_u64_ro);
> + debugfs_create_file("rq_dequeued",S_IRUSR | S_IRGRP | S_IROTH,
checkpatch complains here ^
ERROR: space required after that ',' (ctx:VxV)
Regards,
Horia
