On Tue, Aug 01, 2017 at 11:01:54AM +0200, Stephan Müller wrote: > Am Dienstag, 1. August 2017, 10:58:58 CEST schrieb Herbert Xu: > > Hi Herbert, > > > > This split makes no sense. I don't see why you can't merge them > > into a single patch if it's just rearranging the code. > > If you want to merge all into one patch, I am fine. > > I thought that separating all out makes the patch review easier, considering > that in two or three of the patches, small changes are implemented to allow a > common code base. These changes, however, should not have any functional > effect. How about you separate into three patches? The first two make changes to algif_skcipher/algif_aead so that they can be merged, and the last one does the actual merging. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt