Re: [v3 RFC PATCH 2/2] crypto: ecc: use caller's GFP flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Herbert,

On 07/18/2017 08:52 AM, Herbert Xu wrote:
On Wed, Jun 28, 2017 at 05:08:36PM +0300, Tudor Ambarus wrote:
Using GFP_KERNEL when allocating data and implicitly
assuming that we can sleep was wrong because the caller
could be in atomic context. Let the caller decide whether
sleeping is possible or not.

The caller (ecdh) was updated in the same patch in order
to not affect bissectability.

Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>

Hmm, who wants to do asymmetric key crypto in interrupt context?

I thought of a caller that doesn't set the CRYPTO_TFM_REQ_MAY_SLEEP
flag. As of now I'm not aware of an user who wants asymmetric key
crypto in interrupt context. We can consider this patch superfluous
if CRYPTO_TFM_REQ_MAY_SLEEP is not meaningful for asymmetric key crypto.

Thanks,
ta



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux