On Tue, Jul 18, 2017 at 07:32:41AM +0100, Ard Biesheuvel wrote: > > Because it is slower, and how much slower is architecture dependent > (if your arch has slow multiplication, aes-ti decryption will be dog > slow compared to aes-generic) Right, but does anybody actually care? My guess is that on such a platform aes-generic is going to be dog-slow anyway. > Also, quite a few architectures have table based implementations that > reuse crypto_ft_tab/crypto_fl_tab etc so we'd need to factor out those > into a separate module if we were to remove aes-generic. You mean x86 and arm, right? Isn't the idea of your patch-set to allow aes-generic to be disabled on x86/arm, no? Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt