On Sun, Jul 9, 2017 at 8:43 AM, Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx> wrote: > The assignment operator implicitly converts a void pointer to the type of the > pointer it is assigned to. > > This issue was detected using Coccinelle and the following semantic patch: > > @@ > expression * e; > expression arg1, arg2; > type T; > @@ > > - e=(T*) > + e= > kmalloc(arg1, arg2); > > Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx> For both patches: Acked-by: Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx> > --- > drivers/staging/ccree/ssi_buffer_mgr.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c b/drivers/staging/ccree/ssi_buffer_mgr.c > index b35871e..18a8694 100644 > --- a/drivers/staging/ccree/ssi_buffer_mgr.c > +++ b/drivers/staging/ccree/ssi_buffer_mgr.c > @@ -1725,8 +1725,7 @@ int ssi_buffer_mgr_init(struct ssi_drvdata *drvdata) > struct buff_mgr_handle *buff_mgr_handle; > struct device *dev = &drvdata->plat_dev->dev; > > - buff_mgr_handle = (struct buff_mgr_handle *) > - kmalloc(sizeof(struct buff_mgr_handle), GFP_KERNEL); > + buff_mgr_handle = kmalloc(sizeof(struct buff_mgr_handle), GFP_KERNEL); > if (!buff_mgr_handle) > return -ENOMEM; > > -- > 2.5.0 > Thanks, Gilad -- Gilad Ben-Yossef Chief Coffee Drinker "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru
