Re: [PATCH 00/10] Fix alignment issues in staging/ccree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sun, Jul 2, 2017 at 2:25 AM, Simon Sandström <simon@xxxxxxxxxx> wrote:
> Fixes a total of 195 alignment issues in staging/ccree reported by
> checkpatch.pl. Adds a few "line over 80 characters" warnings as a
> result of the realignments, but I could try to get rid of them in the
> same patchset if needed.

For the large majority of warnings there is nothing you can due ti the
indentation depth,
but for the few cases where its a complex expression that can be
broken down like this one:

WARNING: line over 80 characters
#93: FILE: drivers/staging/ccree/ssi_buffer_mgr.c:437:
+     (AES_BLOCK_SIZE + areq_ctx->ccm_hdr_size),

It would be great if you fix those.

Otherwise it looks good to me.

Thanks for doing it!

Gilad



>
> -- Simon
>
> ---
>
> Simon Sandström (10):
>   staging: ccree: Fix alignment issues in ssi_aead.c
>   staging: ccree: Fix alignment issues in ssi_buffer_mgr.c
>   staging: ccree: Fix alignment issues in ssi_cipher.c
>   staging: ccree: Fix alignment issues in ssi_driver.c
>   staging: ccree: Fix alignment issues in ssi_fips_local.c
>   staging: ccree: Fix alignment issues in ssi_hash.c
>   staging: ccree: Fix alignment issues in ssi_ivgen.c
>   staging: ccree: Fix alignment issues in ssi_request_mgr.c
>   staging: ccree: Fix alignment issues in ssi_sram_mgr.c
>   staging: ccree: Fix alignment issues in ssi_sysfs.c
>
>  drivers/staging/ccree/ssi_aead.c        |  67 ++++----
>  drivers/staging/ccree/ssi_buffer_mgr.c  | 295 ++++++++++++++++++--------------
>  drivers/staging/ccree/ssi_cipher.c      |  75 ++++----
>  drivers/staging/ccree/ssi_driver.c      |  40 ++---
>  drivers/staging/ccree/ssi_fips_local.c  |   3 +-
>  drivers/staging/ccree/ssi_hash.c        | 116 +++++++------
>  drivers/staging/ccree/ssi_ivgen.c       |   3 +-
>  drivers/staging/ccree/ssi_request_mgr.c |  42 +++--
>  drivers/staging/ccree/ssi_sram_mgr.c    |   6 +-
>  drivers/staging/ccree/ssi_sysfs.c       |  59 ++++---
>  10 files changed, 372 insertions(+), 334 deletions(-)
>
> --
> 2.11.0
>



-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux