On Wed, Jun 21, 2017 at 05:29:21PM +0300, Radu Solea wrote: > Generic GCM is likely to end up using a hardware accelerator to do > part of the job. Allocating hash, iv and result in a contiguous memory > area increases the risk of dma mapping multiple ranges on the same > cacheline. Also having dma and cpu written data on the same cacheline > will cause coherence issues. > > Signed-off-by: Radu Solea <radu.solea@xxxxxxx> > --- > Hi! > > I've encountered cache coherence issues when using GCM with CAAM and this was > one way of fixing them but it has its drawbacks. Another would be to allocate > each element instead of all at once, but that only decreases the likelyhood of > this happening. Does anyone know of a better way of fixing this? I don't get it. You're modifying the software version of GCM, and the function is marked as static. How can this patch have any effect on CAAM? Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt