Hi Herbert, thanks for effort reviewing on those patches. By the way, also loop in Torsten Could you kindly guide me how to determine appropriate rng->ops.quality value used by the driver? There is less clues since the value is not being set in most drivers. But good value decided would allow feeding fresh entropy data with the hwrng so i would like add it in the next patch. I have tested with rngtest on mtk-cir and the result is got as the below log shown. If the rngtest always gives the result for success rate over 99.8%, can I set the rng->ops.quality 998? rngtest: starting FIPS tests... rngtest: bits received from input: 20000032 rngtest: FIPS 140-2 successes: 998 rngtest: FIPS 140-2 failures: 2 rngtest: FIPS 140-2(2001-10-10) Monobit: 1 rngtest: FIPS 140-2(2001-10-10) Poker: 0 rngtest: FIPS 140-2(2001-10-10) Runs: 1 rngtest: FIPS 140-2(2001-10-10) Long run: 0 rngtest: FIPS 140-2(2001-10-10) Continuous run: 0 rngtest: input channel speed: (min=715.902; avg=3846.234; max=3906250.000)Kibits/s rngtest: FIPS tests speed: (min=35.453; avg=37.862; max=38.300)Mibits/s rngtest: Program run time: 5591758 microseconds rngtest: starting FIPS tests... rngtest: bits received from input: 20000032 rngtest: FIPS 140-2 successes: 1000 rngtest: FIPS 140-2 failures: 0 rngtest: FIPS 140-2(2001-10-10) Monobit: 0 rngtest: FIPS 140-2(2001-10-10) Poker: 0 rngtest: FIPS 140-2(2001-10-10) Runs: 0 rngtest: FIPS 140-2(2001-10-10) Long run: 0 rngtest: FIPS 140-2(2001-10-10) Continuous run: 0 rngtest: input channel speed: (min=715.588; avg=4424.787; max=4882812.500)Kibits/s rngtest: FIPS tests speed: (min=35.785; avg=37.859; max=38.223)Mibits/s rngtest: Program run time: 4947950 microseconds On Tue, 2017-06-20 at 11:40 +0800, Herbert Xu wrote: > On Mon, Jun 12, 2017 at 11:56:53PM +0800, sean.wang@xxxxxxxxxxxx wrote: > > From: Sean Wang <sean.wang@xxxxxxxxxxxx> > > > > Changes since v1: > > - update the bindings with the specific "mediatek,mt7622-rng" > > instead of the generic one as "mediatek,generic-rng" > > > > The series add support of hardware RNG on MediaTek MT7622 and > > , runtime PM support and add me as the maintainer for the existing > > and following chipset. > > > > Sean Wang (3): > > dt-bindings: rng: add MediaTek MT7622 Hardware Random Generator > > bindings > > hwrng: mtk - add runtime PM support > > MAINTAINERS: add entry for MediaTek Random Number Generator > > All applied. Thanks.
