On Mon, Jun 19, 2017 at 01:27:08PM +0800, Herbert Xu wrote: > On Tue, Jun 06, 2017 at 03:44:17PM +0200, Corentin Labbe wrote: > > The crypto engine could actually only enqueue hash and ablkcipher request. > > This patch permit it to enqueue skcipher requets by adding all necessary > > functions. > > The only problem is that ablkcipher and skcipher id are the same, so > > only one cipher type is usable on the same crypto engine. > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie@xxxxxxxxx> > > I think this should be done as part of the skcipher conversion rather > than as a standalone patch. > Since there are two different user of "crypto engine + ablkcipher", it will be not easy to convert them in one serie. (I could do it, but I simply could not test it for OMAP (lack of hw)) And any new user which want to use crypto engine+skcipher (like me with the sun8i-ce driver) are simply stuck. Regards