Zhang Shengju <zhangshengju@xxxxxxxxxxxxxxxxxxxx> wrote: > It is better to propagate PTR_ERR value instead of a hardcoded > value(-ENOMEM here). > > Signed-off-by: Zhang Shengju <zhangshengju@xxxxxxxxxxxxxxxxxxxx> ... > - return -ENOMEM; > + return PTR_ERR(ctx-wmem); Please test your patches before submission. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt