On Tue, Jun 06, 2017 at 07:47:57PM +0200, Jason A. Donenfeld wrote: > It's not safe to use weak random data here, especially for the challenge > response randomness. Since we're always in process context, it's safe to > simply wait until we have enough randomness to carry out the > authentication correctly. > > While we're at it, we clean up a small memleak during an error > condition. What was the testing that was done for commit? It looks safe, but I'm unfamiliar enough with how the iSCSI authentication works that I'd prefer getting an ack'ed by from the iSCSI maintainers or alternativel, information about how to kick off some kind of automated test suite ala xfstests for file systems. Thanks, - Ted
