On Tue, 2017-05-23 at 14:09 +0200, Corentin Labbe wrote: > By adding a struct device *dev to struct engine, we could store the > device used at register time and so use all dev_xxx functions instead of > pr_xxx. trivia: > diff --git a/include/crypto/engine.h b/include/crypto/engine.h [] > @@ -58,6 +58,7 @@ struct crypto_engine { > struct list_head list; > spinlock_t queue_lock; > struct crypto_queue queue; > + struct device *dev; Probably nicer to align to column for consistency struct device *dev;