Hi Krzysztof On 21 May 2017 at 11:56, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > On Sun, May 21, 2017 at 8:09 AM, PrasannaKumar Muralidharan > <prasannatsmkumar@xxxxxxxxx> wrote: >> As cra_ctxsize is set but the allocated space is not used, set it 0. > > Why do you think it is not used? Did you test our change on hardware? Had a look at the crypto rng code. I think the additional size is used to store driver private data. But this driver does not store any private data in the crypto_tfm structure so I think the 'cra_ctxsize' can be safely set to 0. I do not have access to the hardware, did not test the change. Sorry I forgot to mention that. > Best regards, > Krzysztof > >> >> Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@xxxxxxxxx> >> --- >> drivers/crypto/exynos-rng.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/crypto/exynos-rng.c b/drivers/crypto/exynos-rng.c >> index 451620b..d009df6 100644 >> --- a/drivers/crypto/exynos-rng.c >> +++ b/drivers/crypto/exynos-rng.c >> @@ -260,7 +260,7 @@ static int exynos_rng_kcapi_init(struct crypto_tfm *tfm) >> .cra_name = "stdrng", >> .cra_driver_name = "exynos_rng", >> .cra_priority = 100, >> - .cra_ctxsize = sizeof(struct exynos_rng_ctx), >> + .cra_ctxsize = 0, >> .cra_module = THIS_MODULE, >> .cra_init = exynos_rng_kcapi_init, >> } >> -- >> 1.8.5.6 >> Regards, PrasannaKumar
