On 10 May 2017 at 01:20, Eric Biggers <ebiggers3@xxxxxxxxx> wrote: > From: Eric Biggers <ebiggers@xxxxxxxxxx> > > mix_columns() contains a comment which shows the matrix used by the > MixColumns step of AES, but the last entry in this matrix was incorrect > --- and did not match the code, which is correct. Fix the comment. > > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx> > --- > crypto/aes_ti.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/crypto/aes_ti.c b/crypto/aes_ti.c > index 92644fd1ac19..03023b2290e8 100644 > --- a/crypto/aes_ti.c > +++ b/crypto/aes_ti.c > @@ -114,7 +114,7 @@ static u32 mix_columns(u32 x) > * | 0x2 0x3 0x1 0x1 | | x[0] | > * | 0x1 0x2 0x3 0x1 | | x[1] | > * | 0x1 0x1 0x2 0x3 | x | x[2] | > - * | 0x3 0x1 0x1 0x3 | | x[3] | > + * | 0x3 0x1 0x1 0x2 | | x[3] | > */ > u32 y = mul_by_x(x) ^ ror32(x, 16); > Acked-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
