Hi Antoine, On 24/04/17 08:54, Antoine Tenart wrote: > Add support for Inside Secure SafeXcel EIP197 cryptographic engine, > which can be found on Marvell Armada 7k and 8k boards. This driver > currently implements: ecb(aes), cbc(aes), sha1, sha224, sha256 and > hmac(sah1) algorithms. > > Two firmwares are needed for this engine to work. Their are mostly used > for more advanced operations than the ones supported (as of now), but we > still need them to pass the data to the internal cryptographic engine. > > Signed-off-by: Antoine Tenart <antoine.tenart@xxxxxxxxxxxxxxxxxx> [...] > diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c > new file mode 100644 > index 000000000000..9cb3d0832835 > --- /dev/null > +++ b/drivers/crypto/inside-secure/safexcel.c > @@ -0,0 +1,925 @@ > +/* > + * Copyright (C) 2017 Marvell > + * > + * Antoine Tenart <antoine.tenart@xxxxxxxxxxxxxxxxxx> > + * > + * This file is licensed under the terms of the GNU General Public > + * License version 2. This program is licensed "as is" without any > + * warranty of any kind, whether express or implied. > + */ > + > +#include <linux/clk.h> > +#include <linux/device.h> > +#include <linux/dmapool.h> > +#include <linux/firmware.h> > +#include <linux/interrupt.h> > +#include <linux/module.h> > +#include <linux/of_platform.h> > +#include <linux/of_irq.h> > +#include <linux/platform_device.h> > +#include <linux/workqueue.h> > + > +#include <asm/dma-mapping.h> <linux/dma-mapping.h> everywhere, please. Other than that, the DMA aspects all look much nicer now, thanks. Robin.