Re: [PATCH] crypto: tcrypt: Zero iv before freeing it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 23, 2017 at 09:11:04PM +0200, Stephan Müller wrote:
> Am Sonntag, 23. April 2017, 18:12:04 CEST schrieb Codarren Velvindron:
> 
> Hi Codarren,
> 
> > Signed-off-by: Codarren Velvindron <codarren@xxxxxxxxxx>
> > ---
> >  crypto/tcrypt.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
> > index 9a11f3c..48a721c 100644
> > --- a/crypto/tcrypt.c
> > +++ b/crypto/tcrypt.c
> > @@ -384,7 +384,7 @@ static void test_aead_speed(const char *algo, int enc,
> > unsigned int secs, out_noaxbuf:
> >  	testmgr_free_buf(xbuf);
> >  out_noxbuf:
> > -	kfree(iv);
> > +	kzfree(iv);
> 
> Why would you think this is needed?
> 
>        if (iv_len)
>               memset(iv, 0xff, iv_len);
> 
> 
> Ciao
> Stephan
Hello, 

Thanks for bringing this up to my attention.

Kindly disregard the patch.

Best Regards,
Codarren



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux