Re: [PATCH] crypto: testmgr: clean up memory for sensitive information

[Stephan Müller <smueller@xxxxxxxxxx>]

Am Sonntag, 23. April 2017, 01:40:56 CEST schrieb Pirabarlen-Cheenaramen:

Hi Pirabarlen,

> Signed-off-by: Pirabarlen-Cheenaramen <selven@xxxxxxxxxx>
> ---
>  crypto/testmgr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/crypto/testmgr.c b/crypto/testmgr.c
> index cd075c7..0af2e16 100644
> --- a/crypto/testmgr.c
> +++ b/crypto/testmgr.c
> @@ -953,8 +953,8 @@ static int __test_aead(struct crypto_aead *tfm, int enc,
> out_noaxbuf:
>  	testmgr_free_buf(xbuf);
>  out_noxbuf:
> -	kfree(key);
> -	kfree(iv);
> +	kzfree(key);
> +	kzfree(iv);
>  	return ret;

Hm, I do not think that key or IV are sensitive in this case.

	memcpy(key, template[i].key, template[i].klen);

	if (template[i].iv)
                        memcpy(iv, template[i].iv, iv_len);
                else
                        memset(iv, 0, MAX_IVLEN);


Ciao
Stephan