-----Original Message----- From: Michael Ellerman [mailto:mpe@xxxxxxxxxxxxxx] Sent: Friday, April 07, 2017 4:22 PM To: Laurentiu Tudor <laurentiu.tudor@xxxxxxx>; Horia Geantă <horia.geanta@xxxxxxx>; Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>; Scott Wood <oss@xxxxxxxxxxxx>; Roy Pledge <roy.pledge@xxxxxxx> Cc: Claudiu Manoil <claudiu.manoil@xxxxxxx>; Cristian Stoica <cristian.stoica@xxxxxxx>; Dan Douglass <dan.douglass@xxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Vakul Garg <vakul.garg@xxxxxxx>; linuxppc-dev@xxxxxxxxxxxxxxxx; David S. Miller <davem@xxxxxxxxxxxxx>; Alexandru Porosanu <alexandru.porosanu@xxxxxxx>; linux-crypto@xxxxxxxxxxxxxxx Subject: Re: [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms Importance: High Laurentiu Tudor <laurentiu.tudor@xxxxxxx> writes: > On 04/05/2017 01:06 PM, Michael Ellerman wrote: >> Laurentiu Tudor <laurentiu.tudor@xxxxxxx> writes: >> >>> Hi Michael, >>> >>> Just a couple of basic things to check: >>> - was the dtb updated to the newest? >> >> Possibly not, it's an automated build/boot, I'll have to check what >> it does with the dtb. >> >>> - is the qman node present? This should be easily visible in >>> /proc/device-tree/soc@ffe000000/qman@318000. >> >> No it's not there. >> >> That's running linux-next with: >> >> CONFIG_CRYPTO_DEV_FSL_CAAM_CRYPTO_API_QI=n >> >> >> Does that mean I didn't update the device tree? > > I think so. Also, I just checked that the node is actually there by > compiling p5020ds.dts and then decompiling the dtb. > OK, I'll make sure I update the DTB. > > It will still be good if the code was a bit more robust about the qman being missing. Totally agree. We should handle this error condition. --- Thanks & Best Regards, Laurentiu
