Hi Ondrej, On Sun, Apr 02, 2017 at 09:19:12PM +0200, Ondrej Mosnacek wrote: > This patchset contains the following gf128mul-related changes: > 1. The gf128mul_x_* functions are moved to gf128mul.h for performance reasons. > 2. The gf128mul_x_ble function is fixed to use the correct block type. > 3. The le128_gf128mul_x_ble function from glue_helper.h is removed and its > usages replaced with gf128mul_x_ble calls. > 4. The now obsolete dependency of CRYPTO_XTS on CRYPTO_GF128MUL is removed. > > v4 -> v5: added the other three patches > v3 -> v4: a faster version of gf128mul_x_lle > v2 -> v3: constant-time implementation > v1 -> v2: move all _x_ functions to the header, not just gf128mul_x_ble > > Ondrej Mosnacek (4): > crypto: gf128mul - define gf128mul_x_* in gf128mul.h > crypto: gf128mul - switch gf128mul_x_ble to le128 > crypto: glue_helper - remove the le128_gf128mul_x_ble function > crypto: xts - drop gf128mul dependency These all look good to me, and you can add Reviewed-by: Eric Biggers <ebiggers@xxxxxxxxxx> to the patches. I think the change to le128 is an improvement, but what I've actually wanted to do is have the GF(2^128) elements strongly typed, with ble128, bbe128, and lle128 types, so that the types would reflect both the bit order and the byte order. But that's harder to do and I ran into some issues when I tried it last. - Eric
