Re: [PATCH 4/5] crypto/nx: Add P9 NX support for 842 compression engine.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Haren Myneni <haren@xxxxxxxxxxxxxxxxxx> writes:
> @@ -656,13 +953,21 @@ static __init int nx842_powernv_init(void)
>  	BUILD_BUG_ON(DDE_BUFFER_ALIGN % DDE_BUFFER_SIZE_MULT);
>  	BUILD_BUG_ON(DDE_BUFFER_SIZE_MULT % DDE_BUFFER_LAST_MULT);
>
> -	for_each_compatible_node(dn, NULL, "ibm,power-nx")
> -		nx842_powernv_probe(dn);
> +	if (is_vas_available()) {
> +		for_each_compatible_node(dn, NULL, "ibm,xscom")
> +			nx842_powernv_probe_vas(dn);

I'm not keen on how the device bindings work, instead, I think firmware
should provide a 'ibm,vas' compatible node, rather than simply searching
through all the ibm,xscom nodes.

XSCOMs aren't something that Linux should really know about, it's a
debug interface, and one we use through PRD to do PRD-things, XSCOMs
aren't part of the architecture.

-- 
Stewart Smith
OPAL Architect, IBM.




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux