Re: [PATCH 6/7] crypto: aes - split off shared AES tables and key expansion routines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 26 March 2017 at 20:50, Nicolas Pitre <nicolas.pitre@xxxxxxxxxx> wrote:
> On Sun, 26 Mar 2017, Ard Biesheuvel wrote:
>
>> [...]
>> +static const u32 rco_tab[10] = { 1, 2, 4, 8, 16, 32, 64, 128, 27, 54 };
>
> You could consider using u8 for this table. This is a tiny space saving
> and normally it shouldn't make the runtime any slower on most
> architectures.
>

There is no performance concern here: this variable is only used by
the key expansion routine. I'll propose to change it at the next
occasion



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux