On Fri, Mar 24, 2017 at 05:45:41PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > > And I think the probe might be called twice, for example in case of > > > > mistake in DTB. > > > > > > Even if this is possible resource allocation code in the driver will > > > take take care of handling it just fine, > > > > Indeed, the devm_ioremap_resource() solves the case. I can drop the > > check then. > > Looking on this a bit more it seems that devm_ioremap_resource() will > not cover all mistakes (using compatible by mistake in some other DTB > node). > > Leave the check, I take my objection back. Great! Thanks for feedback. Best regards, Krzysztof