On Tue, Mar 21, 2017 at 5:13 PM, Stephan Müller <smueller@xxxxxxxxxx> wrote: > Am Dienstag, 21. März 2017, 11:59:54 CET schrieb Harsh Jain: > > Hi Harsh, > >> > Executing this command on a 4.9 kernel, I get: >> > >> > bin/kcapi -x 2 -c "gcm(aes)" -i 0d92aa861746b324f20ee6b7 -k >> > f4a6a5e5f2066f6dd9ec6fc5169c29043560ef595c9e81e76f42d29212cc581c -a "" -t >> > "5f24c68cbe6f32c29652442bf5d483ad" -q "" >> > EBADMSG >> >> Probably because s/w implementation is not trying to access dst sg >> pointer because there's nothing to copy in destination buffer. 1 >> question If we don't have data to copy to destination buffer what >> should dst pointer contains? > > The dst SGL should simply be discarded by implementations in the case you > mention above. > > The implementation receives the tag size and the supplied input buffer. If > that input buffer length is equal to the tag length (i.e. no AAD and no > ciphertext), why would the dst SGL be ever touched during decrytion? Yes, Driver can figure out when to discard dst SGL but for that Driver has to put checks before accessing dst SGL. Isn't better if AF_ALG sends NULL for dst SGL. > > Ciao > Stephan
