On Fri, Mar 17, 2017 at 06:28:29PM +0100, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Friday, March 17, 2017 04:49:22 PM Krzysztof Kozlowski wrote: > > Driver uses threaded interrupt handler so there is no real need for > > using spinlocks for synchronization. Mutexes would do fine and are > > friendlier for overall system preemptivness and real-time behavior. > > Are you sure that this conversion is safe? This driver also uses > a tasklet and tasklets run in the interrupt context. > Yes, you're right. This is not safe and patch should be dropped. Thanks for spotting this. Best regards, Krzysztof