Am Donnerstag, 16. März 2017, 10:52:48 CET schrieb Herbert Xu: Hi Herbert, > First of all you're only limiting the amount of memory occupied > by the SG list which is not the same thing as the memory pinned > down by the actual recvmsg. I am fully aware of that. As this was present in the code, I thought I could reuse that approach. Are you saying that you want to stop this approach? > > More importantly, with the current code, a very large recvmsg > would still work by doing it piecemeal. This piecemeal would be done in the sync case. In the current AIO code path, such piecemeal would not be achieved. > With your patch, won't > it fail because sock_kmalloc could fail to allocate memory for > the whole thing? I this case yes. To handle AIO and sync in a common code path (and thus make both behave identically), this would be the result. If very large recvmsg requests are to be handled, the socket option could be increased or the caller would piecemeal that request. Otherwise, if do a piecemeal handling like it is done now, I see the following drawbacks: - no common sync/AIO code and no common behavior - no common approach between skcipher and other implementations (algif_aead and the algif_akcipher that I have in the pipe which looks identically to the proposed patchset) Ciao Stephan
