On Fri, Jan 20, 2017 at 06:07:04PM +0100, Cyrille Pitchen wrote: > Hi all, > > Le 13/01/2017 à 12:39, Herbert Xu a écrit : > > On Fri, Jan 13, 2017 at 12:36:56PM +0100, Stephan Müller wrote: > >> > >> I thought I understood that you would not want to see it in any > >> implementation. But, ok, if you want to leave it. > > > > If you remove it from authenc then authenc will be broken. > > > > Hence if the copy of the associated data is needed in the crypto/authenc.c > driver, then I should also keep this copy in the drivers/crypto/atmel-aes.c > for authenc(hmac(shaX),cbc-aes) algorithms [1], shouldn't I? > > If so, should I keep the current not optimized implementation of > atmel_aes_authenc_copy_assoc() or try to use the code extracted by Stephan > from crypto/authenc.c using the null cipher as proposed in this thread? > > As said earlier in this thread, copying the associated data is not a so big > deal when compared to the main crypto processing. Please just ignore this for now. We have not decided to require the copying of the AAD in the kernel API. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
