On Thu, Jan 19, 2017 at 01:08:11PM -0500, Brijesh Singh wrote: > The CCP device is part of the AMD Secure Processor. In order to expand the > usage of the AMD Secure Processor, create a framework that allows functional > components of the AMD Secure Processor to be initialized and handled > appropriately. What do you mean by "framework"? What is this for? Who is going to use it? Don't add framework that is not ever used, otherwise we will just delete it. > > Signed-off-by: Brijesh Singh <brijesh.singh@xxxxxxx> > Signed-off-by: Tom Lendacky <thomas.lendacky@xxxxxxx> > --- > drivers/crypto/ccp/Kconfig | 1 > drivers/misc/amd-sp/Kconfig | 16 +- > drivers/misc/amd-sp/Makefile | 11 + > drivers/misc/amd-sp/ccp-dev-v3.c | 86 +++++----- > drivers/misc/amd-sp/ccp-dev-v5.c | 72 ++++---- > drivers/misc/amd-sp/ccp-dev.c | 137 +++++++++------- > drivers/misc/amd-sp/ccp-dev.h | 35 ---- > drivers/misc/amd-sp/sp-dev.c | 309 +++++++++++++++++++++++++++++++++++ > drivers/misc/amd-sp/sp-dev.h | 141 ++++++++++++++++ > drivers/misc/amd-sp/sp-pci.c | 325 +++++++++++++++++++++++++++++++++++++ > drivers/misc/amd-sp/sp-platform.c | 269 +++++++++++++++++++++++++++++++ > 11 files changed, 1225 insertions(+), 177 deletions(-) > create mode 100644 drivers/misc/amd-sp/sp-dev.c > create mode 100644 drivers/misc/amd-sp/sp-dev.h > create mode 100644 drivers/misc/amd-sp/sp-pci.c > create mode 100644 drivers/misc/amd-sp/sp-platform.c This patch makes no sense, you need to break it up into "do one logical thing", as that is NOT what is happening here. It's impossible to review as-is, sorry. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
