On Thu, Jan 12, 2017 at 04:50:46PM +0100, Stephan Müller wrote: > > So you say that we could remove it from authenc() entirely (this is currently > the only location where such copy operation is found for the encryption > direction)? > > I would concur that the kernel does not need that. authenc needs it for performance reasons. The kernel API as it stands basically says that it may or may not copy the AAD. If you choose to have a distinct AAD in the dst SG list then either you throw away the result or you copy it yourself. > If we only want to solve that for algif_aead, wouldn't it make more sense if > the user space caller takes care of that (such as libkcapi)? By tinkering with > the SGLs and copying the data to the dst buffer before the cipher operation > takes place, I guess we will add performance degradation and more complexity > in the kernel. > > Having such logic in user space would keep the algif_aead cleaner IMHO. We need to have a sane kernel API that respects POSIX. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
