On Monday, January 2, 2017 1:13:24 PM CET Javier Martinez Canillas wrote: > Hello Arnd, > > On 01/02/2017 01:05 PM, Arnd Bergmann wrote: > > On Monday, January 2, 2017 12:38:02 PM CET Javier Martinez Canillas wrote: > >> If the driver is built as a module, autoload won't work because the module > >> alias information is not filled. So user-space can't match the registered > >> device with the corresponding module if the device isn't registered via OF. > >> > >> Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > > > I think we can just remove the table, as the platform only supports > > booting through DT anyway. > > > > Agreed. I should had checked if mach-picoxcell was DT-only indeed. > > Should I also make the driver to depend on OF and remove the #ifdefery then? I don't think we need a dependency, the #ifdef checks in there were needed only to make the driver smaller if OF is disabled and it should still build fine if someone tries to compile it for CONFIG_COMPILE_TEST without CONFIG_OF. If we remove the platform ID, we can however also remove the spacc_is_compatible() function and just call of_device_is_compatible() in its place. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
