On Fri, Dec 16, 2016 at 01:27:50PM +0100, Stephan Müller wrote:
> Am Freitag, 16. Dezember 2016, 19:54:36 CET schrieb Herbert Xu:
>
> Hi Herbert,
>
> > On Tue, Dec 13, 2016 at 09:42:45PM +0100, Stephan Müller wrote:
> > > + /*
> > > + * The async operation may have processed only a subset of
> > > + * the data that was initially received from the caller.
> > > + * Thus, we only can release the data that a cipher operation
> > > + * processed.
> > > + */
> > > + if (len < sg->length) {
> > > + /* ensure that empty SGLs are not referenced any more */
> > > + sreq->tsg = sg;
> >
> > Hmm if you change sreq->tsg how is the original tsg ever going to
> > get freed?
>
> You are right, this will introduce a memleak. But with the immediate freeing
> of sreq->tsg in the current code, the AIO interface cannot support multiple
> IOCBs.
>
> Thus, the entire memory handling in the AIO case seems broken.
Right, but can we please fix it properly? For example, you could
save the original tsg in a new field and free that when you are
done.
Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
