Re: Remaining crypto API regressions with CONFIG_VMAP_STACK

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/12/2016 12:34 PM, Andy Lutomirski wrote:

<...snip...>


I have a patch to make these depend on !VMAP_STACK.

        drivers/crypto/ccp/ccp-crypto-aes-cmac.c:105,119,142
        drivers/crypto/ccp/ccp-crypto-sha.c:95,109,124
        drivers/crypto/ccp/ccp-crypto-aes-xts.c:162
        drivers/crypto/ccp/ccp-crypto-aes.c:94

According to Herbert, these are fine.  I'm personally less convinced
since I'm very confused as to what "async" means in the crypto code,
but I'm going to leave these alone.

I went back through the code, and AFAICT every argument to sg_init_one() in
the above-cited files is a buffer that is part of the request context. Which
is allocated by the crypto framework, and therefore will never be on the stack.
Right?

I don't (as yet) see a need for any patch to these. Someone correct me if I'm
missing something.

<...snip...>

--
This is my day job. Follow me at:
IG/Twitter/Facebook: @grhookphoto
IG/Twitter/Facebook: @grhphotographer
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux