Re: [PATCH] crypto: ccp - Fix handling of RSA exponent on a v5 device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/16/2016 03:01 AM, Herbert Xu wrote:
On Tue, Nov 15, 2016 at 03:41:25PM -0600, Gary R Hook wrote:
On 11/13/2016 03:49 AM, Herbert Xu wrote:
On Tue, Nov 01, 2016 at 02:05:05PM -0500, Gary R Hook wrote:
The exponent size in the ccp_op structure is in bits. A v5
CCP requires the exponent size to be in bytes, so convert
the size from bits to bytes when populating the descriptor.

The current code references the exponent in memory, but
these fields have not been set since the exponent is
actually store in the LSB. Populate the descriptor with
the LSB location (address).

Signed-off-by: Gary R Hook <gary.hook@xxxxxxx>

Patch applied.  Thanks.


Thanks, Herbert.

Is there a possibility of getting this pushed to 4.9, being
it's a bug fix?

I thought ccp doesn't support RSA yet or is there another entry
path into this code?

The kernel crypto layer does not yet support RSA, true. However, we
designed the ccp.ko layer to be available to anyone that wants to use
it. The underlying module currently has differing behavior/results
between the v3 and v5 implementations of the RSA command function.
This patch fixes the borked v5 code.


--
This is my day job. Follow me at:
IG/Twitter/Facebook: @grhookphoto
IG/Twitter/Facebook: @grhphotographer
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux