On 2016/11/16 09:02PM, Michael Ellerman wrote: > "Naveen N. Rao" <naveen.n.rao@xxxxxxxxxxxxxxxxxx> writes: > > > ..as stray .S files result in build errors, especially when using > > cross-compilers. > > They should be cleaned on make clean, so adding them to clean-files > seems correct. > > > More specifically, the generated .S files are endian-specific and will break > > subsequent builds targeting the other endian architecture. > > But that indicates we're missing an if_changed somewhere, ie. switching > endian should cause them to be regenerated. > > Also they should be generated into $(obj) not $(src) I think. > > How about this? Nice! > > diff --git a/drivers/crypto/vmx/Makefile b/drivers/crypto/vmx/Makefile > index de6e241..52f6ae9 100644 > --- a/drivers/crypto/vmx/Makefile > +++ b/drivers/crypto/vmx/Makefile > @@ -10,10 +10,10 @@ endif > quiet_cmd_perl = PERL $@ > cmd_perl = $(PERL) $(<) $(TARGET) > $(@) > Looks like we also need: targets += aesp8-ppc.S ghashp8-ppc.S > -$(src)/aesp8-ppc.S: $(src)/aesp8-ppc.pl > - $(call cmd,perl) > +$(obj)/aesp8-ppc.S: $(src)/aesp8-ppc.pl FORCE > + $(call if_changed,perl) > > -$(src)/ghashp8-ppc.S: $(src)/ghashp8-ppc.pl > - $(call cmd,perl) > +$(obj)/ghashp8-ppc.S: $(src)/ghashp8-ppc.pl FORCE > + $(call if_changed,perl) > > .PRECIOUS: $(obj)/aesp8-ppc.S $(obj)/ghashp8-ppc.S I will send a v2 with these changes. Thanks, Naveen -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
