On 11/13/2016 03:39 AM, Herbert Xu wrote:
On Fri, Nov 04, 2016 at 11:04:32AM -0500, Gary R Hook wrote:
+ ctx->u.rsa.pkey.e = mpi_read_raw_data(raw_key.e, raw_key.e_sz);
+ if (!ctx->u.rsa.pkey.e)
+ goto e_ret;
+ ctx->u.rsa.e_buf = mpi_get_buffer(ctx->u.rsa.pkey.e,
+ &ctx->u.rsa.e_len, NULL);
You're converting a raw integer into an MPI and then back again.
Why?
In general drivers shouldn't touch the MPI stuff at all since the
hardware generally deals with raw integers.
D'oh! Yes, I see now what I missed before.
I will send out another patch set.
--
This is my day job. Follow me at:
IG/Twitter/Facebook: @grhookphoto
IG/Twitter/Facebook: @grhphotographer
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
