On Tue, Oct 25, 2016 at 07:34:43PM +0000, Trond Myklebust wrote: > > > On Oct 25, 2016, at 14:45, J. Bruce Fields <bfields@xxxxxxxxxxxx> wrote: > > > > From: "J. Bruce Fields" <bfields@xxxxxxxxxx> > > > > As of ac4e97abce9b "scatterlist: sg_set_buf() argument must be in linear > > mapping", sg_set_buf hits a BUG when make_checksum_v2->xdr_process_buf, > > among other callers, passes it memory on the stack. > > > > We only need a scatterlist to pass this to the crypto code, and it seems > > like overkill to require kmalloc'd memory just to encrypt a few bytes, > > but for now this seems the best fix. > > > > Note many of these callers are in the NFS write paths, so we shouldn't > > really be allocating GFP_KERNEL. But we already have other allocations > > in these code paths. A larger redesign may be necessary to allow > > allocations to be done earlier. > > NACK… I agree that there may already be borkage in RPCSEC_GSS-land, but that’s not a reason to be adding to the pile of things that need to be fixed… The allocations that lie in the RPC client’s encode/decode path do need to be GFP_NOFS…. OK. Any disadvantage to keeping this patch with just GFP_NOFS allocations everywhere that might be in the write path? --b. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
