Re: [PATCH v2] crypto: mxs-dcp - Remove hash support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/24/2016 06:43 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@xxxxxxx>
> 
> mxs-dcp driver does not probe for a long time:
> 
> mxs-dcp 80028000.dcp: Failed to register sha1 hash!
> mxs-dcp: probe of 80028000.dcp failed with error -22
> 
> There were some previous attempts to fix this, and the following
> feedback was given by Herbert Xu [1]:
> 
> "This driver is hopelessly broken as its request context doesn't
> contain the hash state at all.  Unless someone can fix that we
> should probably just remove the hash implementations altogether."

This comment looks real unhelpful. I'd really appreciate a bit more
detail on how to fix it.

> [1] http://www.spinics.net/lists/linux-crypto/msg18187.html
> 
> So remove the hash support for now.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx>
> ---
> Changes since v1:
> - Fix typo in commit log
> 

Can't you rather fix it?

-- 
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux