On Mon, Oct 10, 2016 at 12:26:00PM +0100, Ard Biesheuvel wrote: > > /* This piece of crap needs to disappear into per-type test hooks. */ > if (!((type ^ CRYPTO_ALG_TYPE_BLKCIPHER) & > CRYPTO_ALG_TYPE_BLKCIPHER_MASK) && !(type & CRYPTO_ALG_GENIV) && > ((alg->cra_flags & CRYPTO_ALG_TYPE_MASK) == > CRYPTO_ALG_TYPE_BLKCIPHER ? alg->cra_blkcipher.ivsize : > alg->cra_ablkcipher.ivsize)) > type |= CRYPTO_ALG_TESTED; > > This causes cbc(aes), ctr(aes) and xts(aes) to remain untested, unless > I add CRYPTO_ALG_GENIV to their cra_flags. Is this expected behavior? > What would be your recommended way to ensure these algos are covered > by the boottime tests? This is a leftover from the old blkcipher/ablkcipher interface. I've got a patch pending which will remove this if clause. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
