On Fri, Sep 23, 2016 at 08:22:27PM -0400, Jan Stancek wrote: > > This seems to directly correspond with: > p8_ghash_alg.descsize = sizeof(struct p8_ghash_desc_ctx) == 56 > shash_tfm->descsize = sizeof(struct p8_ghash_desc_ctx) + crypto_shash_descsize(fallback) == 56 + 20 > where 20 is presumably coming from "ghash_alg.descsize". > > My gut feeling was that these 2 should match, but I'd love to hear > what crypto people think. Indeed. The vmx driver is broken. It is allocating a fallback but is not providing any space for the state of the fallback. Unfortunately our interface doesn't really provide a way to provide the state size dynamically. So what I'd suggest is to fix the fallback to the generic ghash implementation and export its state size like we do for md5/sha. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
