On Thu, Sep 22, 2016 at 05:22:44PM +0800, Herbert Xu wrote: > I'm suggesting that we have just one set of buffers for all scomp > algorithms. After all, a CPU can only process one request at a > time. Makes sense. Implemented in v8. > Yes scomp should just be flat. A sync algorithm capable of producing > partial output should use the acomp interface. I went back to scomp interface in v6. > > I think you may have misread my earlier message from June. What > I'd like to see is for the acomp layer to allocate the output > memory, rather than have it provided by the user as is the case > with the current interface. The user could provide a maximum to > prevent crazy cases consuming unlimited memory. Why would you prefer to have the output buffer allocated in the acomp layer? Is there a use case for this? Who would free that memory? We believe that the output buffer should be allocated by the user of the API. A caller might decide to allocate memory upfront or point the buffer list to pre-allocate buffers. This would happen in BTRFS where its block buffers are already allocated for submission to the compression API. Thanks, -- Giovanni -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
