Hi Corentin, On Fri, Aug 26, 2016 at 10:38:02AM +0200, LABBE Corentin wrote: > On Thu, Aug 25, 2016 at 02:56:38PM +0000, Jason Cooper wrote: > > On Thu, Aug 25, 2016 at 02:16:35PM +0200, LABBE Corentin wrote: > > > This patch convert the hwrng interface used by amd768-rng to its new API > > > by replacing data_read()/data_present() by read(). > > > > > > Furthermore, Instead of having two global variable, it's better to use a > > > private struct. This will permit to remove amd_pdev variable. > > > > > > Finally, Instead of accessing hw directly via pmbase, it's better to > > > access after ioport_map() via ioread32/iowrite32. > > > > I was going to recommend a better $subject line, but now I see why it's > > vague. :( I would recommend breaking this patch up into three: > > > > hwrng: amd - Access hardware via ioread32/iowrite32 > > hwrng: amd - Replace global variable with private struct > > hwrng: amd - Convert to new hwrng read() API > > > > That was my first idea, but believed that it wasnt worth it. When working with crypto/rng code, I'm a firm believer in moving cautiously and deliberately. :-) > Anyway I will do it. Thanks! thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
