[cryptodev:master 116/131] drivers/crypto/qce/ablkcipher.c:229:1: warning: 'qce_ablkcipher_crypt' uses dynamic stack allocation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head:   98eca72fa04a9bbf28dba95efaec5aa95588fe23
commit: 2d20ce070d3b78f0974408ef648223967d0efb0a [116/131] crypto: qce - Use skcipher for fallback
config: s390-allyesconfig (attached as .config)
compiler: s390x-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 2d20ce070d3b78f0974408ef648223967d0efb0a
        # save the attached .config to linux build tree
        make.cross ARCH=s390 

All warnings (new ones prefixed by >>):

   drivers/crypto/qce/ablkcipher.c: In function 'qce_ablkcipher_crypt':
>> drivers/crypto/qce/ablkcipher.c:229:1: warning: 'qce_ablkcipher_crypt' uses dynamic stack allocation
    }
    ^

vim +/qce_ablkcipher_crypt +229 drivers/crypto/qce/ablkcipher.c

ec8f5d8f6 Stanimir Varbanov 2014-06-25  213  	if (IS_AES(rctx->flags) && ctx->enc_keylen != AES_KEYSIZE_128 &&
ec8f5d8f6 Stanimir Varbanov 2014-06-25  214  	    ctx->enc_keylen != AES_KEYSIZE_256) {
2d20ce070 Herbert Xu        2016-06-29  215  		SKCIPHER_REQUEST_ON_STACK(subreq, ctx->fallback);
2d20ce070 Herbert Xu        2016-06-29  216  
2d20ce070 Herbert Xu        2016-06-29  217  		skcipher_request_set_tfm(subreq, ctx->fallback);
2d20ce070 Herbert Xu        2016-06-29  218  		skcipher_request_set_callback(subreq, req->base.flags,
2d20ce070 Herbert Xu        2016-06-29  219  					      NULL, NULL);
2d20ce070 Herbert Xu        2016-06-29  220  		skcipher_request_set_crypt(subreq, req->src, req->dst,
2d20ce070 Herbert Xu        2016-06-29  221  					   req->nbytes, req->info);
2d20ce070 Herbert Xu        2016-06-29  222  		ret = encrypt ? crypto_skcipher_encrypt(subreq) :
2d20ce070 Herbert Xu        2016-06-29  223  				crypto_skcipher_decrypt(subreq);
2d20ce070 Herbert Xu        2016-06-29  224  		skcipher_request_zero(subreq);
ec8f5d8f6 Stanimir Varbanov 2014-06-25  225  		return ret;
ec8f5d8f6 Stanimir Varbanov 2014-06-25  226  	}
ec8f5d8f6 Stanimir Varbanov 2014-06-25  227  
ec8f5d8f6 Stanimir Varbanov 2014-06-25  228  	return tmpl->qce->async_req_enqueue(tmpl->qce, &req->base);
ec8f5d8f6 Stanimir Varbanov 2014-06-25 @229  }
ec8f5d8f6 Stanimir Varbanov 2014-06-25  230  
ec8f5d8f6 Stanimir Varbanov 2014-06-25  231  static int qce_ablkcipher_encrypt(struct ablkcipher_request *req)
ec8f5d8f6 Stanimir Varbanov 2014-06-25  232  {
ec8f5d8f6 Stanimir Varbanov 2014-06-25  233  	return qce_ablkcipher_crypt(req, 1);
ec8f5d8f6 Stanimir Varbanov 2014-06-25  234  }
ec8f5d8f6 Stanimir Varbanov 2014-06-25  235  
ec8f5d8f6 Stanimir Varbanov 2014-06-25  236  static int qce_ablkcipher_decrypt(struct ablkcipher_request *req)
ec8f5d8f6 Stanimir Varbanov 2014-06-25  237  {

:::::: The code at line 229 was first introduced by commit
:::::: ec8f5d8f6f76b939f662d6e83041abecabef0a34 crypto: qce - Qualcomm crypto engine driver

:::::: TO: Stanimir Varbanov <svarbanov@xxxxxxxxxx>
:::::: CC: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data


[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux