> -----Original Message----- > From: Herbert Xu [mailto:herbert@xxxxxxxxxxxxxxxxxxx] > Sent: Tuesday, June 21, 2016 12:49 AM > To: Benedetto, Salvatore <salvatore.benedetto@xxxxxxxxx> > Cc: linux-crypto@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v9 2/3] crypto: kpp - Add DH software implementation > > On Mon, Jun 20, 2016 at 11:43:28AM +0000, Benedetto, Salvatore wrote: > > > > > While you're at it, it would be nice if you could make the encoded > > > format little-endian, that way we can make test vectors for all kpp > > > algorithms use the same format. > > > > > > > The input format is the same for DH and ECDH. > > Only the software implementation of ECC requires little-endian format. > > What I mean is to get rid of the DH-specific code in testmgr.c and directly > encode the secret into the test vector rather than calling the helper. I prefer to have both DH and ECDH data explicitly encoded with the helpers. One reason is that it will be less work for me when I'll add other curves support to ECDH. If you don't have any strong objections I'd rather leave it as it for now. Regards, Salvatore -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
