> -----Original Message----- > From: Herbert Xu [mailto:herbert@xxxxxxxxxxxxxxxxxxx] > Sent: Monday, June 20, 2016 12:13 PM > To: Benedetto, Salvatore <salvatore.benedetto@xxxxxxxxx> > Cc: linux-crypto@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v9 2/3] crypto: kpp - Add DH software implementation > > On Fri, Jun 17, 2016 at 03:37:44PM +0100, Salvatore Benedetto wrote: > > > > +int crypto_dh_encode_key(char *buf, unsigned int len, const struct dh > > +*params) { > > + struct kpp_secret *secret = (struct kpp_secret *)buf; > > You can't do that. The memory under buf may not be aligned so you need to > copy it. OK, I'll fix that and send a new version unless you have other comments. Thanks for reviewing. Salvatore -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
