On Fri, 17 Jun 2016 13:24:07 +0200 Romain Perier <romain.perier@xxxxxxxxxxxxxxxxxx> wrote: > This commits adds support for fine grained load balancing on > multi-engine IPs. The engine is pre-selected based on its current load > and on the weight of the crypto request that is about to be processed. > The global crypto queue is also moved to each engine. These changes are > required to allow chaining crypto requests at the DMA level. By using > a crypto queue per engine, we make sure that we keep the state of the > tdma chain synchronized with the crypto queue. We also reduce contention > on 'cesa_dev->lock' and improve parallelism. > > Signed-off-by: Romain Perier <romain.perier@xxxxxxxxxxxxxxxxxx> > --- > > Changes in v2: > > - Reworded the commit message > - Moved the code about SRAM I/O operations from this commit to > a separated commit (see PATCH 07/10). > > drivers/crypto/marvell/cesa.c | 30 ++++++++++------------ > drivers/crypto/marvell/cesa.h | 29 +++++++++++++++++---- > drivers/crypto/marvell/cipher.c | 57 ++++++++++++++++++----------------------- > drivers/crypto/marvell/hash.c | 50 ++++++++++++++---------------------- > 4 files changed, 82 insertions(+), 84 deletions(-) > > diff --git a/drivers/crypto/marvell/cesa.c b/drivers/crypto/marvell/cesa.c > index af96426..f9e6688 100644 > --- a/drivers/crypto/marvell/cesa.c > +++ b/drivers/crypto/marvell/cesa.c > @@ -45,11 +45,9 @@ static void mv_cesa_dequeue_req_unlocked(struct mv_cesa_engine *engine) This function should be renamed mv_cesa_dequeue_req_locked(). I see you're doing it in patch 9, but it should be done here. > struct crypto_async_request *req, *backlog; > struct mv_cesa_ctx *ctx; > > - spin_lock_bh(&cesa_dev->lock); > - backlog = crypto_get_backlog(&cesa_dev->queue); > - req = crypto_dequeue_request(&cesa_dev->queue); > + backlog = crypto_get_backlog(&engine->queue); > + req = crypto_dequeue_request(&engine->queue); > engine->req = req; > - spin_unlock_bh(&cesa_dev->lock); > > if (!req) > return; -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
