On Fri, Jun 10, 2016 at 07:56:57AM +0200, Stephan Mueller wrote: > Hardware cipher implementation may require aligned buffers. All buffers > that potentially are processed with a cipher are now aligned. > > At the time of the allocation of the memory, we have not yet allocated > the cipher implementations. Hence, we cannot obtain the alignmask for > the used cipher yet. Therefore, the DRBG code uses an alignment which > should satisfy all cipher implementations. Why not change it so that you allocate these buffers after you have obtained the tfm object? An alignment of 8 doesn't work for padlock at least, but then again the padlock driver doesn't support CTR so it's no big deal. I think if you are going to worry about alignment then let's do it properly and use the actual alignment required. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
