On Fri, Jun 10, 2016 at 04:43:09PM +0200, LABBE Corentin wrote: > > So I need to split do_one_request to cipher_one_request/hash_one_request. > Same with prepare_request to prepare_hash_request/prepare_cipher_request. > With the choice of each function done in crypto_engine.c. Yes. As a general rule we should make sure that the API exposed to driver authors is strongly typed so that they don't have to do casts at all. > Since this modification need to add <crypto/hash.h> to algapi.h, I think it is necessary to move all crypto engine stuff to crypto/engine.h > Do you agree ? That sounds like a good idea. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
