Hi Stephan,
> > int rsa_get_n(void *context, size_t hdrlen, unsigned char tag,
> > const void *value, size_t vlen)
> > {
> > struct rsa_key *key = context;
> > + const u8 *ptr = value;
> > + int ret;
> >
> > - key->n = mpi_read_raw_data(value, vlen);
> > + while (!*ptr && vlen) {
> > + ptr++;
> > + vlen--;
> > + }
>
> As you do this operation 3 times, isn't an inline better here?
Actually this operation makes sense only for n to determine its length.
I will remove the while from rsa_get_e/d.
>
> >
> > - if (!key->n)
> > - return -ENOMEM;
> > + /* invalid key provided */
> > + if (!ptr)
> > + return -EINVAL;
>
> Hm, you check the pointer here, but you dereference it already above. So, I
> guess you want to move that check to the beginning of the function?
Sure. Thank you for reviewing!
ta
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
