-----Original Message----- From: Herbert Xu [mailto:herbert@xxxxxxxxxxxxxxxxxxx] Sent: Thursday, June 2, 2016 5:33 PM To: Dey, Megha <megha.dey@xxxxxxxxx> Cc: tim.c.chen@xxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; linux-crypto@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Yu, Fenghua <fenghua.yu@xxxxxxxxx> Subject: Re: [PATCH 2/2] crypto : async implementation for sha1-mb On Thu, Jun 02, 2016 at 10:20:20AM -0700, Megha Dey wrote: > > > > @@ -439,17 +444,18 @@ static int mcryptd_hash_finup_enqueue(struct > > > ahash_request *req) static void mcryptd_hash_digest(struct > > > crypto_async_request *req_async, int err) { > > > struct mcryptd_hash_ctx *ctx = crypto_tfm_ctx(req_async->tfm); > > > - struct crypto_shash *child = ctx->child; > > > + struct crypto_ahash *child = ctx->child; > > > struct ahash_request *req = ahash_request_cast(req_async); > > > struct mcryptd_hash_request_ctx *rctx = ahash_request_ctx(req); > > > - struct shash_desc *desc = &rctx->desc; > > > + struct ahash_request *desc = &rctx->areq; > > > + struct crypto_async_request *base = &desc->base; > > > > > > if (unlikely(err == -EINPROGRESS)) > > > goto out; > > > + base->tfm = &child->base; > > > + base->flags = CRYPTO_TFM_REQ_MAY_SLEEP; /* check this again */ > > > > You should not be touching crypto_async_request directly. Use the > > proper ahash interface to set the child request. > > > Herbert, Could you please clarify? > In the earlier code we had a async_request which is now replaced by > crypto_async_request. Do you want a new async_request to be used? > Do you think we shouldn't be setting the members of the > crypto_ahash_request directly, but use some other interface to do the > same for us? You already have an ahash_request here. So you should be doing ahash_request_set_tfm(...) ahash_request_set_callback(...) >ok,done! Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
